Skip to content

Renamed sample test name with the correct one #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 24, 2020

Conversation

ajithkumar-maragathavel
Copy link
Contributor

Description

After setting up the MFTF environment with the support of getting started guide,
Then the guide suggests running the AdminLoginTest to verify installation of the MFTF environment by running the below command.

vendor/bin/mftf run:test AdminLoginTest --remove

But in the latest Magento 2.4-develop branch, the MFTF test with the name AdminLoginTest not found anywhere. Therefore It throws error while running the above command.

It is renamed as AdminLoginSuccessfulTest. So renamed the test name in the getting started guide.

Affected Pages

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-engcom-team magento-engcom-team added Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Apr 22, 2020
@coveralls
Copy link

coveralls commented Apr 22, 2020

Coverage Status

Coverage remained the same at 56.074% when pulling c21fdd9 on ajithkumar-maragathavel:sample-test-run into ce889d8 on magento:develop.

@okolesnyk okolesnyk requested review from dobooth and okolesnyk April 23, 2020 14:47
@tomreece tomreece added the DOC label Jul 24, 2020
@tomreece tomreece merged commit 98d9a3b into magento:develop Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOC Partner: Ziffity partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants